Repository navigation
fix: handle single-button gesture follow-ups correctly (#1026) - #1536
Merged
Merged
Conversation
Preserve normal ZCL dispatch and existing Flow contracts for #1026. Add captured-frame behavioral regression coverage and align the first development batch at 0.4.1.
Owner
Author
|
Merged at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captured traffic in #1026 contains a Tuya gesture followed by a standard OnOff command. The old parser can misinterpret the follow-up as another gesture, including a false hold, and intercepts unrelated ZCL traffic.
Recognize only the verified endpoint-1/cluster-6 command 0xFD with its single valid action byte. Native and serialized Buffer captures now produce exactly one existing single/double/hold Flow event per gesture. Forward all other traffic to the original dispatcher with its receiver, metadata, result and errors preserved. Restore the hook safely on reinitialization/deletion and retain SDK cleanup.
Only
smart_remote_1_button_2/device.jschanges runtime behavior. Pairing, capabilities, settings, Flow IDs/action values and protected shared/light sources remain unchanged. No timer debounce or battery feature is introduced.Align package, both lock roots, Compose, generated manifest, channel-neutral changelog and development checks at 0.4.1. Update the roadmap/backlog and add the active preflight and physical Test checklist. main, dev and frozen develop-0.4 are outside this PR.
Validation:
ede8794b9a8152067e633cdb455f1e89115abcf8exactly matches the locally tested tree.Refs #1026. Keep the issue open for physical single/double/hold and existing-Flow acceptance in public Test, plus the separately scoped optional battery request. No physical success or Store publication is claimed.